Configure IPv6 only when VPN is up and fix default route for IPv6 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/hotspot_ynh into set-ipv6-when-openvpn-is-up
|
!testme |
|
✌️ |
|
🪱 |
Firgiveme
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The IPv6 delegated prefix is meant to be used with the VPN client, but the IPv6 address is always configured, even when there is no VPN active.
I also noticed the default route for IPv6 is removed when IPv6 forwarding is enabled.
Solution
I'm configuring the IPv6 in the scripts for the VPN. This way, when the VPN is up, the IPv6 address is added to the wifi interface. Also, when the hotspot is starting, it checks if the VPN is already up before adding the IPv6.
I'm adding back the default route after enabling IPv6 forwarding.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)